From 5755fdaba0ba5206aef97cadeb80c26c99d02235 Mon Sep 17 00:00:00 2001 From: Taylor Otwell Date: Thu, 7 Jul 2011 07:16:20 -0700 Subject: [PATCH] Refactor Str::pool method. --- system/str.php | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/system/str.php b/system/str.php index 7e779b81..c9782279 100644 --- a/system/str.php +++ b/system/str.php @@ -88,17 +88,13 @@ class Str { */ private static function pool($type = 'alnum') { - if ($type == 'alnum') + switch ($type) { - return '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'; - } - elseif ($type == 'alpha') - { - return 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'; - } - else - { - throw new \Exception("Unrecognized random pool [$type]."); + case 'alnum': + return '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'; + + default: + return 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'; } }